🐛✨EC2 machine creation: try to create at least 1 machine

[sanderegg]

What do these changes do?

BEFORE: The autoscaling would try to create up to EC2_INSTANCES_MAX_INSTANCES instances and fail to do so if for example the EC2 number of machines quota is exceeded.
AFTER: The autoscaling will try to create between 1 and EC2_INSTANCES_MAX_INSTANCES instances. so if the quota is exceeded, EC2 will try to create between 1 and the asked number of instances.

Related issue/s

• fixes Computational clusters: when the EC2 vCPU quota is reached the clusters does not start processing osparc-issues#1277

How to test

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)

DevOps Checklist

[matusdrobuliak66]

nice 💯

[mguidon]

Is there any useful log message reported back (through the API server) if we run out of quota?

[sanderegg]

Is there any useful log message reported back (through the API server) if we run out of quota?

@mguidon :

Unexpected error happened when starting EC2 instance: An error occurred (VcpuLimitExceeded) when calling the RunInstances operation: You have requested more vCPU capacity than your current vCPU limit of 1000 allows for the instance bucket that the specified instance type belongs to. Please visit http://aws.amazon.com/contact-us/ec2-request to request an adjustment to this limit.

Not through the api-server though

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.5%. Comparing base (2aa73cc) to head (62d1eb9).
Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5408      +/-   ##
=========================================
  Coverage    87.5%   87.5%              
=========================================
  Files        1322     959     -363     
  Lines       54234   42418   -11816     
  Branches     1175     228     -947     
=========================================
- Hits        47479   37146   -10333     
+ Misses       6506    5223    -1283     
+ Partials      249      49     -200     

Flag	Coverage Δ
integrationtests	64.1% <ø> (-1.0%)	⬇️
unittests	85.0% <100.0%> (-0.5%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/aws-library/src/aws_library/ec2/client.py	100.0% <100.0%> (ø)
...e_service_autoscaling/modules/auto_scaling_core.py	94.3% <100.0%> (ø)
...imcore_service_clusters_keeper/modules/clusters.py	100.0% <ø> (ø)

... and 380 files with indirect coverage changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud