Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Frontend changes for CookieBanner on s4l-io #5413

Merged

Conversation

mrnicegyu11
Copy link
Member

What do these changes do?

Thx to @odeimaiz for actually coding this.

This will correct the links in the frontend cookie banner.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@mrnicegyu11 mrnicegyu11 added a:frontend issue affecting the front-end (area group) High Priority a totally crucial bug/feature to be fixed asap labels Mar 5, 2024
@mrnicegyu11 mrnicegyu11 added this to the Schoggilebe milestone Mar 5, 2024
@mrnicegyu11 mrnicegyu11 requested a review from odeimaiz March 5, 2024 16:46
@mrnicegyu11 mrnicegyu11 changed the title 🎨 Frontend changes for CookieBanner on s4l-lio 🎨 Frontend changes for CookieBanner on s4l-io Mar 5, 2024
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrnicegyu11 mrnicegyu11 enabled auto-merge (squash) March 6, 2024 07:27
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mrnicegyu11 mrnicegyu11 disabled auto-merge March 6, 2024 09:11
@mrnicegyu11 mrnicegyu11 merged commit 5f1bac4 into ITISFoundation:master Mar 6, 2024
49 checks passed
@mrnicegyu11 mrnicegyu11 deleted the fix/cookieBannerLinks branch March 6, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) High Priority a totally crucial bug/feature to be fixed asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants