-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes error upon registration of pending email confirmation #5488
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5488 +/- ##
=========================================
- Coverage 84.5% 82.2% -2.4%
=========================================
Files 10 597 +587
Lines 214 29725 +29511
Branches 25 204 +179
=========================================
+ Hits 181 24436 +24255
- Misses 23 5237 +5214
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
dfb253f
to
db589f7
Compare
|
What do these changes do?
If a user is

CONFIRMATION_PENDING
and tries to register, the webserver responds 500 becauseUserStatus
constructor raisesValuerError
NOTE that the values stored in the database for
UserStatus.CONFIRMATION_PENDING
before this change were not "PENDING" butCONFIRMATION_PENDING
. Therefore this change does not require a database migration script.Related issue/s
How to test
cd packages/postgres-database pytest tests/test_users.py
Dev-ops checklist