Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes error upon registration of pending email confirmation #5488

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Mar 13, 2024

What do these changes do?

If a user is CONFIRMATION_PENDING and tries to register, the webserver responds 500 because UserStatus constructor raises ValuerError
image

NOTE that the values stored in the database for UserStatus.CONFIRMATION_PENDING before this change were not "PENDING" but CONFIRMATION_PENDING. Therefore this change does not require a database migration script.

Related issue/s

How to test

cd packages/postgres-database
pytest tests/test_users.py

Dev-ops checklist

@pcrespov pcrespov self-assigned this Mar 13, 2024
@pcrespov pcrespov added a:webserver issue related to the webserver service a:database associated to postgres service and postgres-database package labels Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (cafbf96) to head (db589f7).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5488      +/-   ##
=========================================
- Coverage    84.5%   82.2%    -2.4%     
=========================================
  Files          10     597     +587     
  Lines         214   29725   +29511     
  Branches       25     204     +179     
=========================================
+ Hits          181   24436   +24255     
- Misses         23    5237    +5214     
- Partials       10      52      +42     
Flag Coverage Δ
integrationtests 64.1% <ø> (?)
unittests 80.1% <ø> (-4.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 607 files with indirect coverage changes

@pcrespov pcrespov marked this pull request as ready for review March 13, 2024 20:15
@pcrespov pcrespov added this to the Schoggilebe milestone Mar 13, 2024
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@pcrespov pcrespov enabled auto-merge (squash) March 14, 2024 08:55
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov merged commit 9403609 into ITISFoundation:master Mar 14, 2024
56 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 3, 2024
37 tasks
@pcrespov pcrespov deleted the fix/user-status branch May 6, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants