-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ api-server: New study jobs metadata entrypoints #5690
✨ api-server: New study jobs metadata entrypoints #5690
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5690 +/- ##
=========================================
- Coverage 84.5% 84.3% -0.3%
=========================================
Files 10 717 +707
Lines 214 34630 +34416
Branches 25 714 +689
=========================================
+ Hits 181 29203 +29022
- Misses 23 5264 +5241
- Partials 10 163 +153
Flags with carried forward coverage won't be shown. Click here to find out more. |
44a19be
to
91ca022
Compare
91ca022
to
59b9799
Compare
59b9799
to
8b8259f
Compare
8d91753
to
a9cfc33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thanks a lot 🚀
services/api-server/src/simcore_service_api_server/api/routes/studies_jobs.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/studies_jobs.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
4bc6be6
to
596b69f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just a few comments you might want to consider
services/api-server/src/simcore_service_api_server/api/routes/studies_jobs.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/studies_jobs.py
Show resolved
Hide resolved
services/api-server/tests/unit/api_studies/test_api_routers_studies_jobs_metadata.py
Outdated
Show resolved
Hide resolved
596b69f
to
63945fe
Compare
|
What do these changes do?
get_study_job_custom_metadata
asGET/{study_id}/jobs/{job_id}/metadata
replace_study_job_custom_metadata
asPUT /{study_id}/jobs/{job_id}/metadata
--spy-httpx-calls-enabled=true
mocked_backend
fixture prototypes how to mock iterable responses. This is a prototype that will eventually move into the implementation ofcreate_respx_mock_from_capture
fixturejobs
business logic toservices
followingcontroller/service/repository
patternRelated issue/s
How to test
Dev-ops checklist