✨ dynamic-services will fail if they have any required input that is not set

[GitHK]

What do these changes do?

Changes

• starting a dynamic-service which has required inputs that are not satisfied (file is missing or link is not present) will display a warning message to the user advising them on what to do.
• if a project is open and an auto started service has required inputs that are not satisfied, this service will not start. If the user presses on it to start a message will be displayed hinting at the problem.

Users warning messages

Case 1 (input link to port is missing)

Case 2 (file in input port not present)

Related issue/s

• requires ✨ introducing inputs_required to workbench #5838
• closes dynamic services fail to boot if input is missing osparc-issues#1453

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 46.29630% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 70.2%. Comparing base (cafbf96) to head (b77c261).
Report is 247 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5845      +/-   ##
=========================================
- Coverage    84.5%   70.2%   -14.4%     
=========================================
  Files          10     553     +543     
  Lines         214   27997   +27783     
  Branches       25     205     +180     
=========================================
+ Hits          181   19656   +19475     
- Misses         23    8290    +8267     
- Partials       10      51      +41     

Flag	Coverage Δ
integrationtests	60.3% <22.2%> (?)
unittests	74.2% <46.2%> (-10.4%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...core_service_webserver/projects/_nodes_handlers.py	91.0% <50.0%> (ø)
...c/simcore_service_webserver/projects/exceptions.py	88.7% <60.0%> (ø)
...simcore_service_webserver/projects/projects_api.py	80.2% <40.5%> (ø)

... and 560 files with indirect coverage changes

[odeimaiz]

Thanks!

[elisabettai]

Very nice! I see how we can apply this to many use-cases. Maybe @wvangeit is interested as well.

So @GitHK. the requirements to use this feature are (please correct me if this is wrong):

1. a service has to be dynamic
2. in the DB, we need to set which inputs are required. Could you maybe add a screenshot that shows that to the PR description?

[GitHK]

Very nice! I see how we can apply this to many use-cases. Maybe @wvangeit is interested as well.

So @GitHK. the requirements to use this feature are (please correct me if this is wrong):

1. a service has to be dynamic

correct both legacy and new style work

2. in the DB, we need to set which inputs are required. Could you maybe add a screenshot that shows that to the PR description?

OM will add an UI element for this a PR will follow

[wvangeit]

One question, I assume that if there is a file from a previous run of the study present, it will pass the test and run the service?

[GitHK]

One question, I assume that if there is a file from a previous run of the study present, it will pass the test and run the service?

Correct. this only checks for the port connections and the presence of a file in the port. It cannot do more that this (like inspecting if a file changes) that requires the sidecar to be running (a.k.a. the service to be running)

[wvangeit]

@GitHK Ok, makes sense.
(@elisabettai so for my use case I can't use it yet, because I need to make sure I get 'fresh' files (i.e. with handshakes))

[sanderegg]

in your PR I see that the error message shows the port key not the port displayed name. Can this not be done otherwise? How as a user will I instantly recognize which port is missing?

[GitHK]

in your PR I see that the error message shows the port key not the port displayed name. Can this not be done otherwise? How as a user will I instantly recognize which port is missing?

So the data is coming from the workbench. I'm not sure exactly how to fetch some more information inside the webserver. I would need to pull the data of all the services that are connecting to my node in order to properly format these messages.

[sanderegg]

👍

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud