Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ introducing elastic file system guardian (OPS ⚠️) #5887

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented May 28, 2024

What do these changes do?

  • ✨ introducing a template for the new service elastic file system guardian
    • Its first functionality will be to manage/monitor AWS EFS (distributed file system), ex. create directories needed for mounting docker volumes, monitor current size, and potentially change directory permissions if needed.

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 88.66667% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 87.4%. Comparing base (cafbf96) to head (489feb8).
Report is 239 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5887      +/-   ##
=========================================
+ Coverage    84.5%   87.4%    +2.8%     
=========================================
  Files          10    1368    +1358     
  Lines         214   56781   +56567     
  Branches       25    1277    +1252     
=========================================
+ Hits          181   49634   +49453     
- Misses         23    6872    +6849     
- Partials       10     275     +265     
Flag Coverage Δ
integrationtests 63.6% <100.0%> (?)
unittests 86.2% <88.6%> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...r-v2/src/simcore_service_director_v2/utils/dask.py 89.8% <100.0%> (ø)
...rdian/src/simcore_service_efs_guardian/__init__.py 100.0% <100.0%> (ø)
...guardian/src/simcore_service_efs_guardian/_meta.py 100.0% <100.0%> (ø)
...rc/simcore_service_efs_guardian/api/rest/health.py 100.0% <100.0%> (ø)
...rc/simcore_service_efs_guardian/api/rest/routes.py 100.0% <100.0%> (ø)
...simcore_service_efs_guardian/api/rpc/rpc_routes.py 100.0% <100.0%> (ø)
...s-guardian/src/simcore_service_efs_guardian/cli.py 100.0% <100.0%> (ø)
...c/simcore_service_efs_guardian/core/application.py 100.0% <100.0%> (ø)
...-guardian/src/simcore_service_efs_guardian/main.py 100.0% <100.0%> (ø)
.../src/simcore_service_efs_guardian/core/settings.py 97.3% <97.3%> (ø)
... and 4 more

... and 1326 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 changed the title ✨ introducing elastic file system guardian ✨ introducing elastic file system guardian (OPS ⚠️) May 28, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Leeroy Jenkins milestone May 28, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 28, 2024 15:43
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome into the fold ;)

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions. Mostly to stress improvements that can be done right away or a bit later

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some comments to consider from my side

Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Looking forward to seeing further developments. Very interesting topic. 👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 30, 2024 14:50
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 merged commit e28db90 into ITISFoundation:master May 31, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants