-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ introducing elastic file system guardian (OPS ⚠️) #5887
✨ introducing elastic file system guardian (OPS ⚠️) #5887
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5887 +/- ##
=========================================
+ Coverage 84.5% 87.4% +2.8%
=========================================
Files 10 1368 +1358
Lines 214 56781 +56567
Branches 25 1277 +1252
=========================================
+ Hits 181 49634 +49453
- Misses 23 6872 +6849
- Partials 10 275 +265
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
welcome into the fold ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions. Mostly to stress improvements that can be done right away or a bit later
services/efs-guardian/src/simcore_service_efs_guardian/rpc/rpc_routes.py
Outdated
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/modules/__init__.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Some comments to consider from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Looking forward to seeing further developments. Very interesting topic. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
|
What do these changes do?
elastic file system guardian
Related issue/s
How to test
Dev-ops checklist