Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Removing default network form agent #5901

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented May 31, 2024

What do these changes do?

The default network is not currently used by the agent service, this not required.
By removing it, it helps in dealing with issues caused by network IP exhaustion.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this May 31, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label May 31, 2024
@GitHK GitHK added this to the Leeroy Jenkins milestone May 31, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.7%. Comparing base (cafbf96) to head (91ba2dd).
Report is 240 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5901      +/-   ##
=========================================
+ Coverage    84.5%   87.7%    +3.2%     
=========================================
  Files          10    1397    +1387     
  Lines         214   57422   +57208     
  Branches       25    1323    +1298     
=========================================
+ Hits          181   50415   +50234     
- Misses         23    6724    +6701     
- Partials       10     283     +273     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 85.8% <ø> (+1.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1368 files with indirect coverage changes

@GitHK GitHK marked this pull request as ready for review May 31, 2024 09:21
@GitHK GitHK changed the title ♻️ Removing default network form agent device ♻️ Removing default network form agent May 31, 2024
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good 👍 thx

@GitHK GitHK enabled auto-merge (squash) May 31, 2024 09:28
@GitHK GitHK merged commit 1c5cf7b into ITISFoundation:master May 31, 2024
56 checks passed
@GitHK GitHK deleted the pr-osparc-drop-network-from-agent branch May 31, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants