Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 propagate job parent ids through api server #5903

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented May 31, 2024

What do these changes do?

  • allow users to set parent_project_id and parent_node_id when creating a study/solver job through the api-server.

Related issue/s

How to test

cd services/api-server/tests/unit && python -m pytest -k test_create

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this May 31, 2024
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label May 31, 2024
@bisgaard-itis bisgaard-itis added this to the Leeroy Jenkins milestone May 31, 2024
@bisgaard-itis bisgaard-itis marked this pull request as ready for review May 31, 2024 16:03
@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner May 31, 2024 16:03
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.6%. Comparing base (cafbf96) to head (87df1c2).
Report is 246 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5903      +/-   ##
=========================================
- Coverage    84.5%   52.6%   -32.0%     
=========================================
  Files          10     486     +476     
  Lines         214   24986   +24772     
  Branches       25     205     +180     
=========================================
+ Hits          181   13147   +12966     
- Misses         23   11788   +11765     
- Partials       10      51      +41     
Flag Coverage Δ
integrationtests 52.6% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 496 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. I left some minor suggestions.

Do not forget to update the openapi.yaml as well!

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) June 3, 2024 09:24
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bisgaard-itis bisgaard-itis merged commit 00b0944 into ITISFoundation:master Jun 3, 2024
57 checks passed
@bisgaard-itis bisgaard-itis deleted the 5881-set-parentids-through-api-server branch June 3, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants