-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 propagate job parent ids through api server #5903
🎨 propagate job parent ids through api server #5903
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5903 +/- ##
=========================================
- Coverage 84.5% 52.6% -32.0%
=========================================
Files 10 486 +476
Lines 214 24986 +24772
Branches 25 205 +180
=========================================
+ Hits 181 13147 +12966
- Misses 23 11788 +11765
- Partials 10 51 +41
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
services/api-server/src/simcore_service_api_server/api/routes/studies.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. I left some minor suggestions.
Do not forget to update the openapi.yaml as well!
services/api-server/src/simcore_service_api_server/api/routes/studies.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services/webserver.py
Outdated
Show resolved
Hide resolved
services/api-server/tests/unit/api_solvers/test_api_routers_solvers_jobs_delete.py
Outdated
Show resolved
Hide resolved
|
What do these changes do?
parent_project_id
andparent_node_id
when creating a study/solver job through the api-server.Related issue/s
How to test
Dev-ops checklist