-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 New pytest-simcore environment_config
fixtures and utils_postgres
helpers
#5909
🔨 New pytest-simcore environment_config
fixtures and utils_postgres
helpers
#5909
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5909 +/- ##
=========================================
- Coverage 84.5% 78.8% -5.8%
=========================================
Files 10 1165 +1155
Lines 214 48699 +48485
Branches 25 821 +796
=========================================
+ Hits 181 38403 +38222
- Misses 23 10132 +10109
- Partials 10 164 +154
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d8be837
to
e46307a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. I would move more of these pytest fixtures out to pytest-simcore. Just a suggestion...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
e46307a
to
f015145
Compare
|
What do these changes do?
Here are some changes in
pytest-simcore
andservicelib
that can be useful in many services. I have used them in some of the services as example and will do systematically with many more in different PRsdocker_compose_service_environment_dict
: replicates the env vars that the real services will encounter.env-devel
and theenvironment
section of aservice_name
. Detects e.g. missing env vars in.env-devel
payments
as example (NOTE: recommended to buildapp_environment
fixture in all services services)pytest_simcore.helpers.utils_postgres.insert_and_get_row_lifespan
context for a control lifespan of a new row.packages/service-library/src/servicelib/fastapi/timing_middleware.py
fromdat-core
serviceRelated issue/s
How to test
in place
Dev-ops checklist
None