🐛Dask sidecar: disable concurrent pulling of files until new version is out #5912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
the
a:dask-service
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5912 +/- ##
=========================================
- Coverage 84.5% 73.5% -11.1%
=========================================
Files 10 128 +118
Lines 214 7013 +6799
Branches 25 0 -25
=========================================
+ Hits 181 5158 +4977
- Misses 23 1855 +1832
+ Partials 10 0 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
sanderegg
requested review from
pcrespov,
GitHK and
matusdrobuliak66
as code owners
sanderegg
force-pushed
the
dask-sidecar/disable-concurrent-pulling
branch
from
2fc541f to
ec2cd86
Compare
GitHK
approved these changes
Jun 6, 2024
|
pcrespov
approved these changes
Jun 6, 2024
This was referenced Jun 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
#5900 showed that if a user runs a computational service with multiple inputs, and these inputs have the same file name, there is a risk of collision. Therefore this PR disable concurrent pulling of inputs (this will slightly reduce execution performance but will ensure that there is no collision).
Bonus:
Related issue/s
How to test
Dev-ops checklist