-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] App Mode: Pop up instructions if any #5915
Merged
odeimaiz
merged 8 commits into
ITISFoundation:master
from
odeimaiz:enh/pop-up-instructions
Jun 5, 2024
Merged
🎨 [Frontend] App Mode: Pop up instructions if any #5915
odeimaiz
merged 8 commits into
ITISFoundation:master
from
odeimaiz:enh/pop-up-instructions
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
pcrespov
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ignapas
approved these changes
Jun 5, 2024
|
sanderegg
approved these changes
Jun 5, 2024
This was referenced Jun 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a:frontend
issue affecting the front-end (area group)
t:enhancement
Improvement or request on an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In order to make the Instructions in the App Mode more visible, we decided to face the user with them when she gets to a step with them.
Related issue/s
related to ITISFoundation/osparc-issues#1309
How to test
Dev-ops checklist