Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] App Mode: Pop up instructions if any #5915

Merged
merged 8 commits into from
Jun 5, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 5, 2024

What do these changes do?

In order to make the Instructions in the App Mode more visible, we decided to face the user with them when she gets to a step with them.

PopUpInstructions

Related issue/s

related to ITISFoundation/osparc-issues#1309

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jun 5, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 5, 2024
@odeimaiz odeimaiz added this to the Leeroy Jenkins milestone Jun 5, 2024
@odeimaiz odeimaiz marked this pull request as ready for review June 5, 2024 08:34
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners June 5, 2024 08:34
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) June 5, 2024 09:26
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit 1f94a48 into ITISFoundation:master Jun 5, 2024
51 checks passed
@odeimaiz
Copy link
Member Author

For the Release Notes:

Instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants