Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom page title #4262

Open
KaiRo-at opened this issue Nov 1, 2020 · 6 comments
Open

Allow custom page title #4262

KaiRo-at opened this issue Nov 1, 2020 · 6 comments
Labels
area/framework Affects third party integration/development enhancement New feature or improvement

Comments

@KaiRo-at
Copy link

KaiRo-at commented Nov 1, 2020

Is your feature request related to a problem? Please describe.

I am running/administrating multiple instances of Icinga Web 2, for my own servers as well as for customers on their systems. In my browser, it would be great if looking at a tab and its title would easily tell me which one I am looking at.

Describe the solution you'd like

One way to do this that sounds easy would be to have the page titles differ. Currently, all end with " :: Icinga Web", but if I could set that string myself, it would be easy to customize this and have them reported differently.
When I locally edit the constant set in https://github.com/Icinga/icingaweb2/blob/master/library/Icinga/Web/Controller/ActionController.php#L51 I can already get this pretty much, so if that "defaultTitle" would be settable via config, this would be pretty helpful and solve the immediate need. There may be some edge cases not caught by that solution but it would be good enough for most cases, IMHO.

Describe alternatives you've considered

Theming and being able to exchange the site icon ("favicon") would be additional help but better to do one step at a time here.

Additional context

Given that the code for setting the page title is already abstracted to using defaultTitle, I would guess the code work to allow setting it via a config does not look like a major piece of work, but can give people like me a big win.

@mwaldmueller
Copy link

I think this is related to #4148

@nilmerg
Copy link
Member

nilmerg commented Nov 2, 2020

Rather related to #4096. Would it be of more advantage to you having this also in the tab title? If so, why?

@nilmerg nilmerg added the needs-feedback We'll only proceed once we hear from you again label Nov 2, 2020
@KaiRo-at
Copy link
Author

KaiRo-at commented Nov 2, 2020

Rather related to #4096. Would it be of more advantage to you having this also in the tab title? If so, why?

For me, only the tab title (and ideally the icon) is the important piece, as I see that before I even open the tab in the browser - be it by hovering the mouse over a tab or also in search results shown when typing in the browser's address bar.

Once I have a tab visible, the content of the page can usually actually tell me what customer's instance this is, and I can set different themes if I want to (including custom one that e.g. display different logos in the right top of the page).

@nilmerg
Copy link
Member

nilmerg commented Nov 2, 2020

For me, only the tab title (and ideally the icon) is the important piece, as I see that before I even open the tab in the browser - be it by hovering the mouse over a tab or also in search results shown when typing in the browser's address bar.

I see. This would also include favorites I guess.

Okay, we'll see what we can do here. Though, once starting to work on this, we should elaborate on whether this is only connected to the instance running Icinga Web 2 or dependent to what is shown by whichever module, or both. (I imagine something like Hosts :: Monitoring :: CustomerA :: Icinga Web or even Hosts :: Monitoring :: CustomerA :: InstanceB :: Icinga Web)

@nilmerg nilmerg added area/framework Affects third party integration/development enhancement New feature or improvement and removed needs-feedback We'll only proceed once we hear from you again labels Nov 2, 2020
@pdolinic
Copy link

pdolinic commented Nov 8, 2021

Currently there is another request present for having Favicons changable:
-> either individual via Module/Theme
-> or preferrably directly via Icingaweb2 (?) (this would make it even easier for everyone)

  • The current only solution is move "/usr/share/icingaweb2/public/img/favicon.png" persistently after package updates, via automated tools/scripts

@pdolinic
Copy link

pdolinic commented Nov 8, 2021

ref/NC/736871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Affects third party integration/development enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

4 participants