build(docker): use wasi-threads #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for itk-wasm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thewtex
force-pushed
the
wasi-threads
branch
5 times, most recently
from
5679b3d to
7ac0d63
Compare
thewtex
changed the title
To address: TypeError: WebAssembly.instantiate(): Import #20 module="env": module is not an object or function
For: wasm-ld: error: lto.tmp: undefined symbol: pthread_atfork wasm-ld: error: lto.tmp: undefined symbol: pthread_attr_setscope
For pthreadShim.c.
To avoid:
CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_C_COMPILE_OBJECT
To address:
/ITKWebAssemblyInterface/src/pthreadShim.cxx:26:2: warning: non-void function does not return a value [-Wreturn-type]
26 | {}
| ^
/ITKWebAssemblyInterface/src/pthreadShim.cxx:33:2: warning: non-void function does not return a value [-Wreturn-type]
33 | {}
| ^
Required for threading. Initial is sufficient for DICOM modules, which require a lot of data (106 pages).
Latest version, SharedMemory support.
thewtex
force-pushed
the
wasi-threads
branch
2 times, most recently
from
9e0a1f3 to
41f114a
Compare
Until wasmtime supports threads in its C-API.
Address pipeline link errors where the function signature changes.
Addresses: wasm-ld: warning: function signature mismatch: __cxa_init_primary_exception >>> defined as (i32, i32, i32) -> i32 in lto.tmp >>> defined as (i32, i32, i32) -> void in libwasi-itk-extras.a(exceptionShim.cxx.o)
For: │ wasm-ld: warning: function signature mismatch: __cxa_init_primary_exception │ >>> defined as (i32, i32, i32) -> i32 in lto.tmp │ >>> defined as (i32, i32, i32) -> void in libwasi-itk-extras.a(exceptionShimInitPrimaryException.cxx.o)
These do not seem to be reliably picked up from the environmental variables anymore.
-Wno-warn-absolute-pathn and -DITK_WASM_NO_FILESYSTEM are only for emscription.
And remove test:wasi:help from test -- crashing on exit for some reason.
Until we provide a jsdelivr web-worker pipeline embedded bundle to use.
For gdcm tests.
Also stub out example data download when not needed.
thewtex
merged commit ad4e0b4
into
InsightSoftwareConsortium:main
58 of 64 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos: