Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Proposal Details Not Fully Displayed on Details Page #2831

Open
kneerose opened this issue Jan 30, 2025 · 4 comments
Open

🐛 Proposal Details Not Fully Displayed on Details Page #2831

kneerose opened this issue Jan 30, 2025 · 4 comments
Assignees
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar

Comments

@kneerose
Copy link
Contributor

kneerose commented Jan 30, 2025

Area

Proposal Pillar

Domain

preview.gov.tools

Which wallet were you using?

No response

Context

While submitting a proposal, I noticed that the proposal details page does not display all the expected information. Only the title, abstract and links are visible after creating a proposal and navigating to its details page, but fields like motivation, rationale, reward address, and amount are missing.

Steps to reproduce

  1. Go to the proposal discussion page on preview.gov.tools.
  2. Open and preview any proposal.
  3. Observe the proposal details section.

Actual behavior

  • Only the title, abstract and links are displayed.
  • Other important fields (e.g., motivation, reward address, and amount) are missing.

Image

Expected behavior

  • The proposal details page should properly display all proposal fields, including:
    1. Motivation
    2. Reward address
    3. amount
    4. Rationale
@bosko-m
Copy link
Contributor

bosko-m commented Feb 3, 2025

@kneerose Im assuming there is a case that is not covered with issue #2649 which is casing this bug.
CC @nebojsact

@kneerose
Copy link
Contributor Author

@nebojsact , the abstract, motivation, rationale, and links content are visible on the card. However, in the case of a treasury proposal, the reward address and amount are missing. Similarly, for an update to the constitution-type proposal, the constitution URL, guardrails script URL, and hash are not displayed. Is this the intended behaviour, or is it a bug?
CC: @bosko-m

@bosko-m
Copy link
Contributor

bosko-m commented Feb 20, 2025

This feels like a bug @kneerose @nebojsact

@kneerose
Copy link
Contributor Author

kneerose commented Feb 21, 2025

@nebojsact , I see that the constitution URL, guardrails script hash, and URL are displayed on the constitution proposal. However, the treasury amount and reward address are missing from the treasury proposal. Additionally, the guardrails script URL and hash have an incorrect test ID labelled rationale-content.

Image

For consistency, the test ID for the constitution URL should be updated to new-constitution-url-content, as the content test IDs for "Review Your Submission" follow a similar pattern. Standardizing these test IDs will improve consistency.
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar
Projects
Status: No status
Status: In QA
Development

No branches or pull requests

3 participants