-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up a demopage #1
Comments
Wow, those look really useful. |
yes, moving test-only codes to Moving plots and IO related codes out can also improve the precompilation.
I just noticed that there's no docs page for MIRT. In that case, I can help set these up in MIRT.jl. But after that, it would still be your work to filling the docs as I know very little about the MIRT internal. |
That would be wonderful. It has been on my "todo" list for a while but I keep working on the code instead of the docs... Having a doc & demo setup would let me move some (perhaps all) of the plots out of the package and into the docs/demos so that the package itself is lighter. Thanks! |
Would you mind checking and updating the demo scripts to make sure it runs without GUI? I'm unfamiliar with the tools you're using and it's a bit challenging for me to adjust the syntax in a way you like. I tried one script but it seems not working now. Line 93 in 360183f
julia> ir_mri_sensemap_sim(dims=N, ncoil=ncoil, orbit_start=90)
ERROR: TypeError: in keyword argument orbit_start, expected AbstractArray{var"#s141",1} where var"#s141"<:Real, got a value of type Int64
Stacktrace:
[1] ir_mri_sensemap_sim(; kwargs::Base.Iterators.Pairs{Symbol,Any,Tuple{Symbol,Symbol,Symbol},NamedTuple{(:dims, :ncoil, :orbit_start),Tuple{Tuple{Int64,Int64},Int64,Int64}}}) at /Users/jc/Documents/Julia/MIRT.jl/src/mri/sensemap-sim.jl:56
[2] top-level scope at REPL[29]:1 |
Oops, this demo needs an update due to some of the breaking changes I've made to MIRT. |
@johnnychen94, |
I'll take a try in the next few days |
Similar to https://juliaimages.org/latest/democards/examples/, I could help set up a demo page here using DemoCards if you like it.
Advantages:
Check and see how demos are organized https://github.com/JuliaImages/juliaimages.github.io/tree/source/docs/examples
Of course, if you want, you could also host demos in the JuliaImages docs repo, people there could help manage and maintain the demos.
The text was updated successfully, but these errors were encountered: