Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating repository and/or consider fixing launching #5

Closed
patricknelson opened this issue Jul 28, 2021 · 3 comments
Closed

Comments

@patricknelson
Copy link
Contributor

patricknelson commented Jul 28, 2021

It appears that the latest version of Windows Terminal now automatically supports opening via explorer shell integration with working directory support (and from what I can tell, bug free). e.g. See: microsoft/terminal#8933

That said: The reason I even noticed was because the app updated itself in the background and right-click integration (manually enabled via these scripts) stopped working since the launch path of C:\Users\USERNAME\AppData\Local\Microsoft\WindowsApps\wt.exe was no longer working for me. So, I'd propose maybe:

  1. Documenting that the functionality available in this repository is probably no longer useful for versions 1.9.x and above
  2. Potentially even archiving this repository (assuming you don't want to maintain backward compatibility for older versions of Windows Terminal, assuming it's even possible to install prior versions)
  3. If not archiving, fix launching of the app. Not sure how this'd be accomplished, since the only path that'd work in my case is C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.9.1942.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe which I assume may vary between either people or versions of the app (not sure).

What do you think?

@JenuelDev
Copy link
Owner

I guess we will mark this repository as deprecated. It seems that the windows terminal context menu is now built in the core of their installation process. I will be archiving the repository as well.

@patricknelson
Copy link
Contributor Author

Alright. And thanks again for building this! I found it incredibly useful and used it daily (since what they had before was either nonexistent or broken).

@JenuelDev
Copy link
Owner

Alright. And thanks again for building this! I found it incredibly useful and used it daily (since what they had before was either nonexistent or broken).

thanks for being a part of this simple project, man :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants