Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proxy colonies M3] feat: implement versioning for all ColonyFundsMovedBetweenFundingPots events #4231

Open
4 tasks
bassgeta opened this issue Feb 3, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@bassgeta
Copy link
Contributor

bassgeta commented Feb 3, 2025

Specification

Story

As a user using an older version of the colony, I can still move funds between domains.

Description

Since a new chainId argument was added to the ColonyFundsMovedBetweenFundingPots event, now when funds are moved, we need to make sure old colony versions will keep working.

Sagas:

  • All sagas for moving funds between pots need to be updated, if the colony runs on a new version, we need to add the chainId as the second to last argument, otherwise not
  • Funding an expenditure sagas should also use the same approach

Block ingestor:

  • For move funds actions, we need to implement a new handler for ColonyFundsMovedBetweenFundingPots events with chainId (basically the same as the old one)
  • for funding an expenditure, we need to update the multisig and motion handlers

Implementation

This issue is complete when...

  • Moving funds between domains still works as intended on old colony versions
  • Moving funds between domains as intended on new colony versions
  • Funding an expenditure still works as intended on old colony versions
  • Funding an expenditure works as intended on new colony versions
@bassgeta bassgeta added the enhancement New feature or request label Feb 3, 2025
@mmioana mmioana assigned mmioana and unassigned mmioana Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants