Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peerDependencies server-runtime #7

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Update peerDependencies server-runtime #7

merged 2 commits into from
Nov 16, 2023

Conversation

justcfx2u
Copy link
Contributor

remix-auth-discord doesn't seem to be installable without this patch.

Quick & dirty, not well tested. It could very well be an incorrect fix, but it gets the code into my environment.

$ npm install remix-auth-discord
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: seco-rmx@undefined
npm ERR! Found: @remix-run/[email protected]
npm ERR! node_modules/@remix-run/server-runtime
npm ERR!   @remix-run/server-runtime@"2.1.0" from @remix-run/[email protected]
npm ERR!   node_modules/@remix-run/dev
npm ERR!     dev @remix-run/dev@"^2.1.0" from the root project
npm ERR!   @remix-run/server-runtime@"2.1.0" from @remix-run/[email protected]
npm ERR!   node_modules/@remix-run/node
npm ERR!     @remix-run/node@"2.1.0" from @remix-run/[email protected]
npm ERR!     node_modules/@remix-run/serve
npm ERR!       peerOptional @remix-run/serve@"^2.1.0" from @remix-run/[email protected]
npm ERR!       node_modules/@remix-run/dev
npm ERR!         dev @remix-run/dev@"^2.1.0" from the root project
npm ERR!     @remix-run/node@"2.1.0" from @remix-run/[email protected]
npm ERR!     node_modules/@remix-run/serve/node_modules/@remix-run/express
npm ERR!       @remix-run/express@"2.1.0" from @remix-run/[email protected]
npm ERR!       node_modules/@remix-run/serve
npm ERR!         peerOptional @remix-run/serve@"^2.1.0" from @remix-run/[email protected]
npm ERR!         node_modules/@remix-run/dev
npm ERR!     1 more (the root project)
npm ERR!   2 more (@remix-run/react, remix-auth)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! remix-auth-discord@"*" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @remix-run/[email protected]
npm ERR! node_modules/@remix-run/server-runtime
npm ERR!   peer @remix-run/server-runtime@"^1.0.0" from [email protected]
npm ERR!   node_modules/remix-auth-discord
npm ERR!     remix-auth-discord@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@JonnyBnator
Copy link
Owner

Nice catch. Apparently I forgot to update the peerDependency.

@JonnyBnator JonnyBnator reopened this Nov 16, 2023
@JonnyBnator JonnyBnator merged commit 21e13d4 into JonnyBnator:master Nov 16, 2023
Repository owner locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants