Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move evaluatable definitions out of EFCore.PG and into the plugin #1

Closed
roji opened this issue May 29, 2020 · 0 comments · Fixed by #2
Closed

Move evaluatable definitions out of EFCore.PG and into the plugin #1

roji opened this issue May 29, 2020 · 0 comments · Fixed by #2
Assignees

Comments

@roji
Copy link

roji commented May 29, 2020

Hi @kinosang, hope you're well and that the plugin is in good shape - saw you released 3.1.0 a few weeks ago, congrats :)

For 5.0, EF Core finally added support for evaluatable filters in plugins (dotnet/efcore#13454), so we can now remove the string-based hack we have in the EFCore.PG provider to support the PGroonga plugin. Here's a PR which does this for the NodaTime type, which you should be able to more or less copy-paste. Once that's done I'll remove the EFCore.PG hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants