Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Reexport Logging? #43

Closed
kescobo opened this issue Mar 10, 2021 · 1 comment · Fixed by #44
Closed

[Request] Reexport Logging? #43

kescobo opened this issue Mar 10, 2021 · 1 comment · Fixed by #44

Comments

@kescobo
Copy link
Contributor

kescobo commented Mar 10, 2021

There's never a time where I do using LoggingExtras that I don't also have to do using Logging. Would there be any objection to using Reexport (Or, since it's a Stdlib and there aren't all that many exports, maybe just do it mannually)? I'd be happy to make a PR, but didn't want to be presumptuous.
@oxinabox
Copy link
Member

yeah, that would be fair.
I think reexporting manually is best.
I would be open to such a PR

@kescobo kescobo mentioned this issue Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-export Logging.jl kescobo/LoggingExtras.jl
2 participants
@kescobo @oxinabox