Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: better account linking #605

Merged
merged 5 commits into from
Sep 5, 2022
Merged

feat!: better account linking #605

merged 5 commits into from
Sep 5, 2022

Conversation

arty-name
Copy link
Collaborator

@arty-name arty-name commented Aug 26, 2022 •
edited
Loading

fixes KILTProtocol/ticket#2040

I have noted for myself a few improvements for account linking code when I was reviewing the package a couple of months ago. The default signer callback was keyring-based, I aligned it with how the sign callbacks work now in the rest of SDK. One comment was perplexing. The verification of potentially prefixed signature could be cleaner.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@arty-name arty-name requested a review from rflechtner August 26, 2022 14:18
@arty-name
Merge branch 'develop' into ta-better-account-linking
66a3e48 
# Conflicts:
#	packages/did/src/DidLinks/AccountLinks.chain.ts
@arty-name
Merge branch 'develop' into ta-better-account-linking
b0525fd 
# Conflicts:
#	packages/did/src/Did.utils.ts
rflechtner
rflechtner approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that is much cleaner! Two things may be investigated before we merge:

  1. Do we actually need to remove the prefix?
  2. Can we use the same sign interface everywhere?

tjwelde
tjwelde reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine with this

@arty-name arty-name merged commit c396dc3 into develop Sep 5, 2022
@arty-name arty-name deleted the ta-better-account-linking branch September 5, 2022 15:47
rflechtner pushed a commit that referenced this pull request Sep 5, 2022
@arty-name @rflechtner
feat!: better account linking (#605)
eef5f8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjwelde tjwelde tjwelde left review comments

@rflechtner rflechtner rflechtner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arty-name @tjwelde @rflechtner