Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove 40+ basic chain wrappers #613

Merged
merged 78 commits into from
Sep 15, 2022
Merged

feat!: remove 40+ basic chain wrappers #613

merged 78 commits into from
Sep 15, 2022

Conversation

arty-name
Copy link
Collaborator

@arty-name arty-name commented Sep 1, 2022 •
edited by tjwelde
Loading

fixes KILTProtocol/ticket#2040

This is what the usage of SDK could look like if we remove the basic wrapper functions.

ToDo

  • Needs a documentation PR with mapping from sdk call to api call

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@arty-name
feat!: removed wrapper AccountLinks.queryDepositAmount
ca019ca
@arty-name
fix: import type ApiPromise
af4821d
@arty-name
feat!: removed wrapper AccountLinks.getAssociateSenderExtrinsic
f58189b
@arty-name
feat!: removed wrapper AccountLinks.getReclaimDepositTx
8f65c4a
@arty-name
feat!: removed wrapper AccountLinks.getLinkRemovalByAccountTx
651ad2d
@arty-name
feat!: removed wrapper Did.Chain.getSetKeyExtrinsic
37aa774
@arty-name
feat!: removed wrapper Did.Chain.getRemoveKeyExtrinsic
716da4d
@arty-name
feat!: removed wrapper Did.Chain.getAddKeyExtrinsic
067556a
@arty-name
feat: added Did.Chain.encodeResourceId
ad1174d
@arty-name
feat!: removed wrapper Did.Chain.getRemoveEndpointExtrinsic
c9ccaf7
@arty-name
fix: test
7654ba6
@arty-name
feat!: removed wrapper Did.Chain.getDeleteDidExtrinsic
1e558b2
@arty-name
feat!: removed wrapper Did.Chain.getReclaimDepositExtrinsic
51cb153
@arty-name
feat!: removed wrapper Did.Chain.queryDepositAmount
17aeb10
@arty-name
feat!: removed wrapper Did.Chain.queryEndpointsCounts
f10e4a8
@arty-name
fix: test should use DidDetails directly
a743ecb
@arty-name
feat!: removed wrapper Did.Chain.queryNonce
143a08f
@arty-name
feat!: removed wrapper Did.Chain.queryDetails
14a3052
@arty-name
feat!: removed wrapper AccountLinks.getAccountSignedAssociationExtrin…
f944c37 
…sic()
@arty-name
feat!: removed wrapper AccountLinks.getLinkRemovalByDidExtrinsic()
cd67be1
@arty-name
feat!: removed wrapper Delegation.getStoreAsDelegationTx
8061310
@arty-name
Merge branch 'develop' into ta-remove-wrappers
842f373 
# Conflicts:
#	packages/core/src/__integrationtests__/Attestation.spec.ts
#	packages/core/src/attestation/Attestation.ts
#	packages/did/src/DidResolver/DidResolver.ts
@arty-name
Merge branch 'develop' into ta-remove-wrappers
c368d12 
# Conflicts:
#	packages/core/src/__integrationtests__/Attestation.spec.ts
#	packages/core/src/__integrationtests__/Blockchain.spec.ts
#	tests/bundle-test.ts
@arty-name
feat!: removed deletedDidsFromChain()
b9679e1
@arty-name
fix: do not decode-encode
bfc1d38
@arty-name
fix: wording in a comment
382c070
@arty-name
fix: lint
fffb8b7
@arty-name
chore: more sensible decoding
d5f5a4b
rflechtner
rflechtner approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to defer the remaining comments to separate tickets as they are mostly optimisations and internals. Let's get the interface out asap and implement these afterwards.

@arty-name arty-name merged commit 1863827 into develop Sep 15, 2022
@arty-name arty-name deleted the ta-remove-wrappers branch September 15, 2022 16:18
This was referenced Sep 16, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntn-x2 ntn-x2 ntn-x2 left review comments

@rflechtner rflechtner rflechtner approved these changes

@tjwelde tjwelde Awaiting requested review from tjwelde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arty-name @tjwelde @ntn-x2 @rflechtner