Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: rename DidDetails to DidDocument #620

Merged
merged 2 commits into from
Sep 6, 2022
Merged

feat!: rename DidDetails to DidDocument #620

merged 2 commits into from
Sep 6, 2022

Conversation

arty-name
Copy link
Collaborator

@arty-name arty-name commented Sep 6, 2022 •
edited
Loading

fixes KILTProtocol/ticket#2040

This name matches its shape and usage much better. Also:

DidResolvedDetails -> DidResolutionResult
DidPublicKey -> ConformingDidKey
DidPublicServiceEndpoint -> ConformingDidServiceEndpoint

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@arty-name
Merge branch 'develop' into ta-rename_DidDetails_to_DidDocument
6b52211 
# Conflicts:
#	packages/messaging/src/Message.spec.ts
rflechtner
rflechtner approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arty-name arty-name merged commit ccb8475 into develop Sep 6, 2022
@arty-name arty-name deleted the ta-rename_DidDetails_to_DidDocument branch September 6, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rflechtner rflechtner rflechtner approved these changes

@tjwelde tjwelde Awaiting requested review from tjwelde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arty-name @rflechtner