Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Did.uriFromChain and encode replaces type cast #633

Merged
merged 2 commits into from
Sep 16, 2022
Merged

feat: Did.uriFromChain and encode replaces type cast #633

merged 2 commits into from
Sep 16, 2022

Conversation

arty-name
Copy link
Collaborator

@arty-name arty-name commented Sep 16, 2022 •
edited
Loading

This PR replaces the type casting of KILT accounts returned from blockchain with encoding them. Many cases don’t even need that, rather they want to get DidUri from blockchain data using Did.uriFromChain().

Inspired by the review comment

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@arty-name arty-name mentioned this pull request Sep 16, 2022
Merged
6 tasks
rflechtner
rflechtner approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@arty-name arty-name merged commit df448db into develop Sep 16, 2022
@arty-name arty-name deleted the ta-encode,_dont_cast branch September 16, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rflechtner rflechtner rflechtner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arty-name @rflechtner