chore: rename DidBuilderError #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arty-name
commented
Sep 27, 2022
| } | ||
| default: | ||
| throw new SDKErrors.DidBuilderError(`Unsupported key type "${type}"`) | ||
| if (type === 'ed25519' || type === 'sr25519') { |
There was a problem hiding this comment.
The function is internal anyway and doesn’t have to check for unexpected broken types.
So we don’t need the default case in the switch (have I said the switch statement is problematic?) and don’t have to throw this error here.
There was a problem hiding this comment.
Is it checked somewhere else, if the type might be broken?
There was a problem hiding this comment.
I guess some user-facing functions do that, but likely not consistently. Still I think the checks should rather be implemented there instead of mistrusting TS all over the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a TODO remnant from #581 and renames a legacy error.
Checklist: