Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: esm imports #700

Merged
merged 3 commits into from
Jan 9, 2023
Merged

fix: esm imports #700

merged 3 commits into from
Jan 9, 2023

Conversation

rflechtner
Copy link
Contributor

fixes KILTProtocol/ticket#2341

fixes KILTProtocol/ticket#2342

Fixes module issues occurring when using the ES6 modules build of the sdk:

  • ESM doesn't support json imports
  • Import of jsonld-signatures, which is CJS-only, needs to follow special rules (named exports are not supported)

How to test:

Use build in an ES6 modules project.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@rflechtner rflechtner requested a review from ntn-x2 January 9, 2023 10:39
@rflechtner rflechtner self-assigned this Jan 9, 2023
ntn-x2
ntn-x2 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rflechtner rflechtner merged commit 18a914d into develop Jan 9, 2023
@rflechtner rflechtner deleted the rf-fix-esm-imports branch January 9, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntn-x2 ntn-x2 ntn-x2 approved these changes

Assignees

@rflechtner rflechtner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rflechtner @ntn-x2