feat: add did contexts #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflechtner
force-pushed
the
rf-did-context
branch
from
babed59 to
227ac42
Compare
ntn-x2
approved these changes
Feb 7, 2023
| * See https://w3c-ccg.github.io/security-vocab/. | ||
| * This document is extended by the context file available under the [[KILT_DID_CONTEXT_URL]]. | ||
| */ | ||
| export const W3C_SECURITY_CONTEXT_URI = 'https://w3id.org/security/v2' |
There was a problem hiding this comment.
This is also a URL tho, right? What about renaming them all to URI? Since the IPFS link is definitely not a URL.
There was a problem hiding this comment.
actually I think I wanted to name it "URL" bc last thing I heard was that the distinction IRI / URI / URL is being abandoned in favour of calling everything "URL". Why is an ipfs link not a URL? It does resolve and thus let you locate a resource, no?
There was a problem hiding this comment.
As far as I know, URL is only used for web resources.
|
@rflechtner I'm merging the PR since I will build on top of this to tackle https://github.com/KILTprotocol/ticket/issues/2093. |
rflechtner
added a commit
that referenced
this pull request
Feb 7, 2023
* feat: static copy of DID json-ld contexts * test: update tests * chore: use shorter ipfs URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/1999
Adds static copies of json-ld context files relevant to KILT DID documents to the sdk, as well as the respective URI to DID documents exported to the conformant json-ld representation.
How to test:
n/a
Checklist: