Sprint 1 #1
Merged
Sprint 1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "homepage": "https://github.com/Karmyshkov/middle.messenger.praktikum.yandex#readme", | ||
| "devDependencies": { | ||
| "@anikin/parcel-transformer-handlebars": "^1.0.9", | ||
| "parcel": "^2.5.0", |
There was a problem hiding this comment.
Лучше задавать фиксированные версии зависимостям.
Если вы однажды решите, удалить package-lock.json файл и попытаться повторно установить зависимости с помощью команды npm install, npm установит последние версии зависимостей, что может привести к ошибкам. Плюс никогда не знаешь в какой версии появляется та или иная уязвимость, поэтому крайне рекомендую использовать статичную версию
src/components/listItem/listItem.hbs
Outdated
| <p class="list-item__message">{{#unless this.countNotReadMessage}}<span class="list-item__message_bold">Вы:</span>{{/unless}} {{this.lastMessage}}</p> | ||
| </div> | ||
| <div class="list-item__wrap"> | ||
| <p class="list-item__time">{{this.time}}</p> |
There was a problem hiding this comment.
Для времени есть специальный тег time
| } | ||
|
|
||
| &__input { | ||
| outline: none; |
There was a problem hiding this comment.
Лучше не отключать свойство outline. Его отключение сильно сказывается на доступности, элемент перестаёт выделяться при фокусе.
| line-height: 9px; | ||
| } | ||
|
|
||
| &__link { |
There was a problem hiding this comment.
Стили дублируются на нескольких страницах
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.