Expose client.endpoints attribute (fixes #641)

[leplatrem]

For Kinto/kinto.js#1751, I was thinking of something like this. Usage would be:

// Replace record endpoint with custom «resource»
kintoClient.endpoints.record = (bucket: string, coll: string, id?: string) =>
   `/custom/url/records` + (id ? `/${id}` : "");

// Add new endpoint
kintoClient.endpoints.changeset = (bucket: string, coll: string) =>
   `${client.endpoints.collection(bucket, coll)}/changeset`

const coll = kintoClient.bucket("bid").collection("cid");
const path = coll.endpoints.changeset(coll.bucket, coll.collection);
const response = await coll.client.execute({ path });

What do you think?

[dstaley]

The first use case (overriding a default endpoint) will work just fine in TypeScript, but the second use case (custom endpoints) might get a bit tricky to represent both accurately and safely as a class property. What if we suggested users create their own endpoint object like this:

const endpoints = {
  ...client.endpoints,
  changeset: (bucket: string, coll: string) =>
    `${client.endpoints.collection(bucket, coll)}/changeset`
};

This would allow TypeScript to correctly type all the properties of endpoints without introducing some complexity into the classes that have a _endpoint property.

[leplatrem]

Thanks!

Based on your feedback (and Ethan's in #743 ) I changed my strategy and I don't think we need the use case of adding of a new endpoint.

[github-actions]

Size Change: +135 B (0%)

Total Size: 38.4 kB

Filename	Size	Change
dist/kinto-http.min.js	8.61 kB	+40 B (0%)
dist/kinto-http.node.js	14.3 kB	+53 B (0%)
dist/moz-kinto-http-client.js	15.5 kB	+42 B (0%)

_{compressed-size-action}

[dstaley]

Nice work! I really like how you figured out a nicer way to stub out the request method.

[glasserc]

LGTM but Dylan's review should supersede mine :)

[leplatrem]

Thanks for your help @dstaley! I think we're good here, I'll merge :)