Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make module dependencies on ITK and VTK explicit #81

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Make module dependencies on ITK and VTK explicit #81

merged 2 commits into from
Jun 27, 2023

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Jun 26, 2023

No description provided.

@dzenanz dzenanz requested review from jcfr and sjh26 June 26, 2023 21:56
@jcfr
Copy link
Contributor

jcfr commented Jun 26, 2023

Could you confirm that the latest changes were integrated to support bundling the extension in a custom application ?

@dzenanz
Copy link
Member Author

dzenanz commented Jun 26, 2023

Yes.

@dzenanz dzenanz merged commit c7b7192 into master Jun 27, 2023
@dzenanz dzenanz deleted the moduleDepends branch June 27, 2023 13:25
@jcfr
Copy link
Contributor

jcfr commented Jun 27, 2023

re: yes

Thanks for confirming. We will have to conditionally list ITK and VTK, I will do a follow-up a pull request

@dzenanz
Copy link
Member Author

dzenanz commented Jul 13, 2023

Is a follow-up PR required?

@jcfr jcfr mentioned this pull request Aug 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfr jcfr Awaiting requested review from jcfr

@sjh26 sjh26 Awaiting requested review from sjh26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzenanz @jcfr