Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility Dialog #20

Open
5 tasks
Grizzly127 opened this issue Jul 6, 2023 · 14 comments
Open
5 tasks

Visibility Dialog #20

Grizzly127 opened this issue Jul 6, 2023 · 14 comments

Comments

@Grizzly127
Copy link
Contributor

Suggestion for the visibility dialog

before:
Bildschirmfoto 2023-07-06 um 11 15 32

after:
Bildschirmfoto 2023-07-06 um 11 18 06
Bildschirmfoto 2023-07-06 um 11 18 16

"Online status" is about if the object is published or not. Since we use "Publish" at the object view to make an object visible for others, I would suggest using "Publish" here too.

  • Can we use only one search field? Or do we need two for groups and persons? @HeyItsBATMAN
  • It looks better to have only one shadow and not three, is this possible to change?
  • Does it make sense to use "whitelist"? Is there a place where you can see or edit a whitelist? -> I would suggest to use the option "Publish only for configured persons/groups". Like this the "Who is able to see my object?" information is not necessary in my opinion.
  • Changing "submit" to "save" ?
  • Change the position of the buttons.

@HeyItsBATMAN @ZetOE @lozanaross

@HeyItsBATMAN
Copy link
Collaborator

I think this is a good attempt at reducing the cognitive load of this form, but maybe it can be simplified even further?

Like, instead of having 2 sliders, this logic could be split into a selection of 3 options:

  • Private (only visible to the current user)
  • Restricted (visible to selected persons and groups)
  • Public (visible to everyone)

Then the person/group selection could be hidden if the object is set to private or public, since it's not needed in those cases anyways.

This is a similar case to the annotation access selection when editing a compilation, as shown in this mockup I did a while back (though I now think Private, Restricted & Public are catchier words):
image


Can we use only one search field? Or do we need two for groups and persons?

This can be combined into one search bar, and this could be done anywhere where groups and persons can be selected.

@Grizzly127
Copy link
Contributor Author

I like the idea.
I tried to implement it:

Bildschirmfoto 2023-07-25 um 12 09 18

Do we need more description (like who can annotate now)? Or do you think it is clear with the words "Private" "Public" and "Restricted"?

@lozanaross
Copy link

I think this looks good & the categories public / private / restricted make sense and can be explained in the new version of the collaboration page. We just need to update the action buttons as per our latest discussion @Grizzly127, otherwise I think this issue can be moved to be on the priority list (@HeyItsBATMAN).

@Grizzly127
Copy link
Contributor Author

here is the latest version with the new secondary button:
Bildschirmfoto 2023-08-17 um 11 53 12

@Grizzly127
Copy link
Contributor Author

Publication/Visibility

I discussed the Publication and Visibility topic with Zoe, since it is still often not clear to the users.
Would it make sense to already do this settings when uploading a new Object?
Therefore there would be an extra step after filling out the Metadata, the formular is the same. The user can decide here if the Object should be downloadble as well.
Bildschirmfoto 2024-08-28 um 13 27 53

Next to the object, there is information about the current visibility of the object
Bildschirmfoto 2024-08-29 um 12 41 09

in the Edit options, you can already edit the Metadata and the Visibility then:
Bildschirmfoto 2024-08-29 um 12 43 57

We should also change this structure of sorting the objects here
Bildschirmfoto 2024-08-29 um 12 38 58
the new structure would be “Private”, “Public” and “Restricted”, just like you can have the settings for the object and keep "Unfinished" for unfinished objects.

I am wondering if we still need the "Publish" button then, when it is about Visibility now and if the user makes the Object "Public", it is basically published, but we didn't call it "Publish", but make it visible for everybody. And since the user could see the visibility status next to the object and edit the status in the edit options, I am not sure if we need the publish button anymore. What is your opinion about that?

@lozanaross @ZetOE

@Grizzly127
Copy link
Contributor Author

small visibility dialog

the small visibility dialog, when clicking edit -> visibility will still look like this, just with the additional download setting and I added the Information box for making clear who can see the object:
Bildschirmfoto 2024-08-29 um 16 14 05

@lozanaross

@lozanaross
Copy link

Publication/Visibility

I discussed the Publication and Visibility topic with Zoe, since it is still often not clear to the users. Would it make sense to already do this settings when uploading a new Object? Therefore there would be an extra step after filling out the Metadata, the formular is the same. The user can decide here if the Object should be downloadble as well.

@Grizzly127 - great, this is a good idea. Window mockup looks good, only we should remove the "test 2" - object name shouldn't be visible in this step I think, only in the smaller dialog (I've noted that on Figma as well)

Next to the object, there is information about the current visibility of the object

Not sure about the position here - might be better to take it out in the action bar - can you make several mockups - one with text, one with icon, and try out several positions? I noted on Figma that we lost track of what is the final object view action bar as we have several variants now with less / more icons.

in the Edit options, you can already edit the Metadata and the Visibility then:

Sure, makes sense.

We should also change this structure of sorting the objects here... the new structure would be “Private”, “Public” and “Restricted”, just like you can have the settings for the object and keep "Unfinished" for unfinished objects.

Yes, agreed.

I am wondering if we still need the "Publish" button then, when it is about Visibility now and if the user makes the Object "Public", it is basically published, but we didn't call it "Publish", but make it visible for everybody. And since the user could see the visibility status next to the object and edit the status in the edit options, I am not sure if we need the publish button anymore. What is your opinion about that?

Agreed, we should get rid of the Publish button.

@Grizzly127
Copy link
Contributor Author

Grizzly127 commented Sep 4, 2024

we should remove the "test 2" - object name shouldn't be visible in this step I think, only in the smaller dialog (I've noted that on Figma as well)

I'm not sure here, because the title of the stepper is "New Object" all the time, because it is the process of adding a new object. Maybe rename it to "add new object", but the title of the object was not meant to be displayed here. We could still remove the object name, because the other settings also don't use the title name again
@lozanaross

@Grizzly127
Copy link
Contributor Author

Position of Visibility status

Not sure about the position here - might be better to take it out in the action bar - can you make several mockups - one with text, one with icon, and try out several positions? I noted on Figma that we lost track of what is the final object view action bar as we have several variants now with less / more icons.

We could have it as a text next to the object and just write "Public", "Private" or "Restricted"
Bildschirmfoto 2024-09-04 um 15 02 33

We could have it as an infobox next to the object, maybe also with the possibility to come quickly to the settings:
Bildschirmfoto 2024-08-29 um 12 36 54

We could use the icons we are using at the settings:
Bildschirmfoto 2024-09-04 um 15 07 50
Bildschirmfoto 2024-09-04 um 15 04 34
Bildschirmfoto 2024-09-04 um 15 04 48

We could add an extra field for the visibility:
Bildschirmfoto 2024-09-04 um 15 08 53
Bildschirmfoto 2024-09-04 um 15 07 02

We could integrate an icon for the status into the actionbar. Since it is not clickable (?) like the other icons and should just be an information, maybe with a tooltip (Infobox like in the screenshot or just "Private", "Public", "Restricted") I made it in blue.
Bildschirmfoto 2024-09-04 um 15 11 15
Bildschirmfoto 2024-09-04 um 15 11 57

Sorry, due to time, I did not always display all options for Public, Private and Restricted. I hope this can still give you an idea about the options. When we decide for what we like most, I can mock up all statuses again.
@lozanaross

@Grizzly127
Copy link
Contributor Author

One more idea:
Add it to the Metadata as an extra point:
Bildschirmfoto 2024-09-24 um 16 10 26
Bildschirmfoto 2024-09-24 um 16 10 40

@lozanaross

@lozanaross
Copy link

we should remove the "test 2" - object name shouldn't be visible in this step I think, only in the smaller dialog (I've noted that on Figma as well)

I'm not sure here, because the title of the stepper is "New Object" all the time, because it is the process of adding a new object. Maybe rename it to "add new object", but the title of the object was not meant to be displayed here. We could still remove the object name, because the other settings also don't use the title name again @lozanaross

@Grizzly127 Good idea, let's change the dialog name to "Add new object". Then remove the object name below for consistency.

@lozanaross
Copy link

lozanaross commented Sep 25, 2024

@Grizzly127 Hm this thing with where we show the visibility status is quite tricky, we don't want it to be too obscure (I think in the action bar as a solo icon is a bit difficult to understand, then users are dependent on the tooltip text). At the same time it shouldn't be quite the same as metadata, because it's not visible to all users at all times - what if it's its own white box / section between the title section and the metadata section (it can also be below metadata, but if the user adds all categories of metadata, that pushes visibility quite far down, possibly below the scroll fold and that is not great, i think the visibility status should be instantly visible near the top of the page). We can even remove the "Visibility" heading, imagine a while narrow section with only a blue pill button that says "public / restricted..." etc and the grey outline info box next to it (not below) - that way the space is optimized a bit better and this visibility thing will anyway not be visible to non-owners, only owners of the object will see this section. If this makes sense and you can mock it up, would be great, just to see.

Bildschirmfoto 2024-09-24 um 16 10 40

@Grizzly127
Copy link
Contributor Author

Good idea! Here is the mockup:
Bildschirmfoto 2024-09-27 um 11 22 59
Bildschirmfoto 2024-09-27 um 11 22 50

For the restricted version: Should the persons be visible here or not?
Bildschirmfoto 2024-09-27 um 11 26 24
Bildschirmfoto 2024-09-27 um 11 27 00

@lozanaross

@Grizzly127
Copy link
Contributor Author

Good idea, let's change the dialog name to "Add new object". Then remove the object name below for consistency.

I changed it:
Bildschirmfoto 2024-09-27 um 11 34 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants