feat(bindings): update FilterPolicy to match AWS API #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you Gadam8 for your first pull request to AsyncAPI.NET repository. Please check out our contributors guide.
|
@dpwdec for reference |
VisualBean
previously approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Looks good. As long as @dpwdec is happy, and this follows the Binding - I dont think there are any problems.
VisualBean
reviewed
Sep 22, 2023
|
@Gadam8 LGTM! I've approved the binding on the AsyncAPI side, just a case of waiting for lead maintainers to approve now. @VisualBean Do you think we should leave this open until a merge goes through on the bindings project? Or can we merge this change now in anticipation of the correction on the bindings side? |
VisualBean
changed the title
|
Binding PR has now been merged asyncapi/bindings#215 |
VisualBean
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Currently, the FilterPolicy configuration does not match what is outlined in the AWS documentation and API - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sns-subscription.html. The FilterPolicy should only contain the JSON policy, so no need for the attributes property; which in itself was confusing as the policy can apply to the message attributes or body.
Further to this, FilterPolicyScope was missing which is needed to determine whether the user wishes to filter on the message attributes or the body. I have a PR raised in the AsyncAPI bindings repo to make the changes to the binding documentation - asyncapi/bindings#215. This has been approved and is awaiting merge.
Changelog
attributesfield and make the object the direct input for the policy