feat: add EigenDA v2 example #206
Conversation
|
|
||
| # To run this example: | ||
| # 0. Ensure you have the latest version of the devnet (see the README for how to install) | ||
| # 1. Clone the https://github.com/Layr-Labs/eigenda repo (and checkout commit a294978e346fe9d7ede0f1a57012c36f64f1212a) |
There was a problem hiding this comment.
Is this commit actually necessary or was it just arbitrarily chosen? I would want to check it in to the eigenda repo and make it part of CI so that it always works with new changes. That should work right and then we can get rid of tis commit requirement?
There was a problem hiding this comment.
Is this commit actually necessary or was it just arbitrarily chosen?
It's necessary. The commit right after this one broke the configuration we were using. More info on #164.
I would want to check it in to the eigenda repo and make it part of CI so that it always works with new changes. That should work right and then we can get rid of tis commit requirement?
That'd be great! 😁
If we do that, I believe we can just remove the example from here and include a link to the EigenDA repo's devnet configuration file.
There was a problem hiding this comment.
I would prefer to make the v2 one work though, given that we are looking to deprecate v1 this year anyways so feels a lot more useful to have a working v2 devnet. How far are you from getting v2 to work? Can I help with anything?
There was a problem hiding this comment.
I still didn't start fully working on the example. We're currently focusing work on the eigenSDKs, but I'll come back to this in a few weeks.
| # NOTE: turning this to 1s causes "referenceBlockNumber is in future" errors | ||
| seconds_per_slot: 3 |
There was a problem hiding this comment.
is this still a real error? Feel like we had talked about this with ian and found a fix to this by using some disperser flag no?
There was a problem hiding this comment.
It is still an error, yeah. We previously had another error when setting this parameter to 12s, which was solved with Ian's help. I think you're referring to that one.
This one is related to a check on the contracts that ensures tasks and task responses aren't included in the same block. Since the devnet is being run locally with small communication delays, it does so almost consistently, so all response submissions revert.
There was a problem hiding this comment.
Hmm intersting. That's weird though since we don't have "tasks" on eigenda. We only have confirmBatches which I'm guessing you are referring to as "task responses". And there's a flag on the batcher (I believe) to set the RBN to a previous block, so I think (?) that should solve this issue as well.
There was a problem hiding this comment.
🤔 I might be misremembering then. I definitely changed the parameter you mentioned when fixing that error when setting 12s block times, which might have solved the 1s slot times too. I'll check it.
This PR renames the current EigenDA example to
examples/eigenda_v1.yamland adds an example for v2.