Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to specify directory for training data, make it CWD (or $HOME/something) by default. #839

Closed
madformuse opened this issue Apr 26, 2019 · 4 comments

Comments

@madformuse
Copy link

I need to add the ability to the client to specify the path to lc0 binary and it's been suggested that similar treatment of networks and data would be beneficial for packaging the application on Linux. Unfortunately It looks like the data writer is currently using the exe directory to create the temporary data folder in and it's not configurable.

It would be better if it either used the current working directory or allowed a temp / data parameter which could be used to specify path. If this was added I could hook into it from the client.

What does everyone else think?

@mooskagh
Copy link
Member

It's a good point. I think it's mostly work on client side than lc0 side, so I created an issue there: LeelaChessZero/lczero-client#92

Everyone feel free to add ideas or implement some parts of it. :)

I'm closing this issue as it (I think) is fully covered by LeelaChessZero/lczero-client#92.

@madformuse
Copy link
Author

I'm not sure it is covered as lc0 is hard coded to use path same directory as binary for temp data.

@mooskagh
Copy link
Member

mooskagh commented May 4, 2019

I meant that PR to cover everything, but it indeed probably makes sense to have Lc0-related issue in Lc0 repo. I'll repurpose this issue then.

@mooskagh mooskagh reopened this May 4, 2019
@mooskagh mooskagh changed the title Use cwd instead of exe dir for data Make it possible to specify directory for training data, make it CWD (or $HOME/something) by default. May 4, 2019
@mooskagh
Copy link
Member

Fixed in #1338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants