Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Fix floating promise in constructor #680

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Fix floating promise in constructor #680

merged 1 commit into from
Oct 3, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Oct 1, 2019 •
edited
Loading

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Oct 1, 2019
@vweevers vweevers mentioned this pull request Oct 1, 2019
Closed
@vweevers vweevers requested a review from ralphtheninja October 1, 2019 08:38
vweevers added a commit to Level/subleveldown that referenced this pull request Oct 1, 2019
@vweevers
Temporarily test against Level/abstract-leveldown#352 and Level/level…
ea315dd 
…up#680
@vweevers vweevers merged commit cf08d94 into master Oct 3, 2019
@vweevers vweevers deleted the fix-floating-promise branch October 3, 2019 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees
No one assigned
Labels
semver-patch Bug fixes that are backward compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

levelup constructor without callback causes unhandled rejection
2 participants
@vweevers @ralphtheninja