-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support profiling and hooks from pl17 from pl 1.6 #14142
Comments
while there is a suspended state with the version, I will request what we need |
Hello! I don't exactly understand what this means:
But here is a PR that will add profiling for the batch transfer hooks. To be clear, there won't be any 1.6.x releases anymore. Any new additions or fixes will land in 1.8dev or 1.7.x depending on whether it is a feature or a fix. |
@awaelchli looks great! FYI: this is not about the new, but about what is already in 1.7 It was previously discussed that if something is needed critical, then it can be added in 1.6: #14086 (comment)
|
Hi, with something critical I meant serious bugs that block a large percentage of users or security patches. We would not backport features into previous releases. Note that this was a suggested potential solution, but there's been no decision on whether we would do this. Does your company require using PyTorch 1.8? Is there a specific reason why you cannot upgrade? |
If I am not wrong! PL==1.7 might not break if you install PT==1.8 again manually |
🚀 Feature
support profiling and hooks from pl17 in pl 1.6, in particular hooks/steps for creating a batch (fetch_batch ) and transferring it to the device - I want to be able to get time for these steps when profiling.
Motivation
due to the fact that in PL 1.7 there is no support for torch 1.8.2, I want PL 1.6 to have useful functions that are in PL 1.7
Submission
Get the opportunity to profile and measure the time at the stage of receiving the batch and transferring the batch to the device.
Alternatives
for good, I want it to be without alternatives, and it was simply implemented as it is in 1.7, tk. we support 1.7 but there are conflicts with the torch version -- we want to keep the lightning and torch versions fully compatible.
Additional context
a question about profiling where the missing steps in 1.6 are indicated
https://pytorch-lightning.slack.com/archives/CRBLFHY79/p1659645752234179
support request sticking out 1.8.2 in pl 1.7
#14086
Rays of love for lightning ⚡
cc @Borda @carmocca @kaushikb11 @ninginthecloud @rohitgr7 @nbcsm @guotuofeng
The text was updated successfully, but these errors were encountered: