Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support teardown for Lightning DataModule #4418

Closed
ananthsub opened this issue Oct 29, 2020 · 1 comment · Fixed by #4673
Closed

Support teardown for Lightning DataModule #4418

ananthsub opened this issue Oct 29, 2020 · 1 comment · Fixed by #4673
Labels
data handling Generic data-related topic feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on

Comments

@ananthsub
Copy link
Contributor

🚀 Feature

teardown as a hook can be useful for data modules.

Motivation

This could be used for:

  • Clean up downloaded data after training finishes
  • Closing any open connections a dataloader makes
  • etc

Pitch

This has natural connections to prepare_data and setup and could be implemented very similarly to how those are supported across the data module and lightning module.

By default this should do nothing

cc @nateraw

@ananthsub ananthsub added feature Is an improvement or enhancement help wanted Open to be worked on labels Oct 29, 2020
@rohitgr7 rohitgr7 added the data handling Generic data-related topic label Oct 29, 2020
@stale
Copy link

stale bot commented Nov 28, 2020

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Nov 28, 2020
@stale stale bot closed this as completed Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data handling Generic data-related topic feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants