Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pl_examples reinforce_learn_qnet wrong argument name and description in argparse #5381

Closed
sidhantls opened this issue Jan 6, 2021 · 0 comments · Fixed by #5414
Closed

pl_examples reinforce_learn_qnet wrong argument name and description in argparse #5381

sidhantls opened this issue Jan 6, 2021 · 0 comments · Fixed by #5414
Labels
bug Something isn't working help wanted Open to be worked on

Comments

@sidhantls
Copy link
Contributor

sidhantls commented Jan 6, 2021

🐛 Bug

In refinforce_learn_qnet.py, the argument parser adds two arguments that the model doesn't take input to: max_episode_reward and warm_start_size. It adds both warm_start_size and warm_start_steps arguments instead of just warm_start_steps. Can be seen here.

warm_start_steps has a wrong description as well (seems to be copied from max_episode_reward). Its description is supposed to be the description of warm_start_size. Can be verified with its implementation in pl bolts

@sidhantls sidhantls added bug Something isn't working help wanted Open to be worked on labels Jan 6, 2021
@sidhantls sidhantls changed the title pl_examples reinforce_learn_qnet wrong argument variable and description in argparse pl_examples reinforce_learn_qnet wrong argument name and description in argparse Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Open to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant