Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve manual_optimization #5769

Closed
tchaton opened this issue Feb 3, 2021 · 0 comments · Fixed by #5771
Closed

Improve manual_optimization #5769

tchaton opened this issue Feb 3, 2021 · 0 comments · Fixed by #5771
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Milestone

Comments

@tchaton
Copy link
Contributor

tchaton commented Feb 3, 2021

🚀 Feature

Motivation

The current manual optimization is not flexible enough.
From discussion with @justusschock and @awaelchli, here is the proposal:

  • manual_backward shouldn't take any optimizers as they aren't used internally expect in Horovod. To solve this, in Horovod, call synchronise on all optimizers.
  • In LightningOptimizer, optimizer shoudn't follow accumulated_grad_batches.

Pitch

Alternatives

Additional context

@tchaton tchaton added feature Is an improvement or enhancement help wanted Open to be worked on labels Feb 3, 2021
@tchaton tchaton added this to the 1.2 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant