Splitting a way corrupts step_count and duration

[DerDings]

Vespucci Version

15.0.4 (probably among others)

Download source

Google Play Store

Device (Manufacturer and Model)

Galaxy Tab A (2016)

Android Version

9

Behaviour/Symptoms

When a way with a value for step_count or duration (e.g. step_count=5) is splitted, two ways are created with the same value for this key, which leads to the total value of both ways being doubled (two ways with step_count=5 in a row => 10 steps in total)

Expected Behaviour

There should be a warning at least, like there is when turning around a one-way street.

How to recreate

1. Find steps that have step_count: https://overpass-turbo.eu/s/YQR.
2. Split the way with Vespucci. (maybe you need to add a new node in the middle first to make it splittable)

Crash dump submitted (no or yes + date)

no

Any other potentially relevant information

same issue in StreetComplete
May be also present in other editors.

[simonpoole]

This equally applies when merging.

To really handle this properly, the relevant tags really need an indication that this is a metric that could change on merging and splitting in the preset configuration.

[DerDings]

Then should it rather be reported to presets?

[simonpoole]

Then should it rather be reported to presets?

Nope, first we need to figure out a reasonable way of handling this, and that needs to be coded first.

[DerDings]

There are vivid discussions on this topic in streetcomplete/StreetComplete#2145 and openstreetmap/iD#8069. We should wait for their outcome to avoid people writing the same stuff three times.

[simonpoole]

parking:lane:both:capacity, parking:lane:left:capacity and parking:lane:right:capacity and the *:disabled variants are candidates for the same treatment.

These are actually more relevant than step_count as they can be tagged on ways that could legitimately be split more often than steps (for example for routes).

[simonpoole]

Fixed in 66729ba for merging and c9978a2 for splitting. As in particular the later commit is rather far reaching I currently don't intend to back port this.

Demo https://twitter.com/vespucci_editor/status/1318221680351862789

Note: currently we don't do anything for closed ways.