Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails with ACF 5.10 #23

Closed
drzraf opened this issue Oct 20, 2021 · 2 comments
Closed

Fails with ACF 5.10 #23

drzraf opened this issue Oct 20, 2021 · 2 comments

Comments

@drzraf
Copy link
Contributor

drzraf commented Oct 20, 2021 •
edited
Loading

Describe the bug
Stopped working with ACF 5.10

To Reproduce
The "Save template" tooltip containing Name the template : * does not show the name text input anymore.

Screenshots
Screenshot from 2021-10-20 15-33-30

WordPress and ACF Versions
WordPress version :
ACF version: 5.10
ACF Pro version: 5.10

The reason is that acf_render_field_label now uses acf_esc_html() which strips the necessary markup.
@MarieComet
Copy link
Owner

Hey, thanks for the report.
Please download the last version of the repository and let me know if that's fixed for you.

@drzraf
Copy link
Contributor Author

drzraf commented Oct 22, 2021

It works!
Thank you!

@drzraf drzraf closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drzraf @MarieComet