-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ranges and pre-release bug #24
Labels
Comments
Yeah, you're right. It does seem like any non-zero value should satisfy |
This sort of thing is why I've imagined the implementation needs to have special values that represent the high (infinity) and low (zero) bounds. |
PR on #25 |
mattfarina
added a commit
that referenced
this issue
Nov 29, 2016
Fixed #24: Fixed edge case issue where constraint "> 0" does not hand…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider the case of a range
> 0
and the versions0.0.1-beta
and0
.This range will return false for both. But, isn't
0.0.1-beta
greater that0
? If a range like> 0-a
is used than a version like0
doesn't work. It's one of those edge cases when #21/#23 was fixed.@technosophos this came about when I was trying to update helm for the latest release to deal with the pre-release issue.
Considering two options:
UsingPrerelease
to force it into place without putting a prerelease on the constraint.@technosophos @sdboyer thoughts?
The text was updated successfully, but these errors were encountered: