Fixes #21: pre-releases not API compatible #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per SemVer, pre-releases are not API compatible with the releases at the same point. The range comparisons have been updated to: - if the constraint does not have a pre-release then versions with a pre-release are not compatible. - if the constraint has a pre-release than versions with a pre-release are evaluated.
|
LGTM |
|
Yeah, LGTM. This'll be more involved for 2.x, though it shouldn't be terrible - and actually simpler implementation than the one I had in mind for this general problem space, anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per SemVer, pre-releases are not API compatible with the releases
at the same point. The range comparisons have been updated to:
with a pre-release are not compatible.
pre-release are evaluated.