Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker: Fix flatpickrWrapper is not defined error #5363

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

panmona
Copy link
Contributor

@panmona panmona commented Mar 13, 2024

First of all thanks for maintaining this library!

When updating from Blazorise 1.3.3 to the newest 1.4.3, we started to notice the following error logs in the console:

datePicker.js?v=1.4.3.0:118 Uncaught ReferenceError: flatpickrWrapper is not defined
    at ClassWatcher.successClassAddHandler [as classAddedCallback] (datePicker.js?v=1.4.3.0:118:17)
    at MutationObserver.mutationCallback (observer.js?v=1.4.3.0:90:30)

The component behavior seems to still be as excepted though.

I suspect that this is because in #5093 the successClassAddHandler functions were moved outside of the scope where the flatpickrWrapper is available. In the PR I unfortunately wasn't able to see why this was changed. The PR seems to me a bit unrelated to those functions.
I'm very open to change the PR if my analysis was incorrect!

Copy link
Contributor

github-actions bot commented Mar 13, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@panmona
Copy link
Contributor Author

panmona commented Mar 13, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 13, 2024
Copy link
Collaborator

@stsrki stsrki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not sure how we missed that as it seems pretty obvious not to be placed there.

Thank you for the contribution!

@stsrki stsrki mentioned this pull request Mar 13, 2024
@stsrki stsrki changed the title Datepicker: Fix flatpickrWrapper is not defined error DatePicker: Fix flatpickrWrapper is not defined error Mar 13, 2024
@stsrki stsrki merged commit b33b139 into Megabit:master Mar 13, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@panmona panmona deleted the fix-datepicker-js branch March 15, 2024 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants