Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check: Add Group Name parameter #5372

Merged
merged 8 commits into from
Mar 25, 2024

Conversation

adamhathcock
Copy link
Contributor

Checkboxes do behave as a group if named the same so add that like Radios

Copy link
Contributor

github-actions bot commented Mar 18, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@adamhathcock
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 18, 2024
@stsrki
Copy link
Collaborator

stsrki commented Mar 18, 2024

I wasn't aware that name is valid on the checkbox, only on the radio. But according to MDN(https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/checkbox#handling_multiple_checkboxes) it seems to be valid HTML.

I think it would be best to rename the parameter as Name, instead of Group. It is more per HTML specs. Agree?

Also it would be great if you could add an example in the docs.

@adamhathcock
Copy link
Contributor Author

Sure about Name. I was just following what radio did

I'll add docs too

@adamhathcock
Copy link
Contributor Author

Thanks, I wasn't aware all that was needed!

Copy link
Collaborator

@stsrki stsrki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution.

@stsrki stsrki changed the title Add Group Name to Check Check: Add Group Name parameter Mar 25, 2024
@stsrki stsrki mentioned this pull request Mar 25, 2024
@stsrki stsrki merged commit b654447 into Megabit:master Mar 25, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants