Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectInstance.GetItemsByItemTypeAndEvaluatedInclude allocates ~0.8% of open solution #2283

Closed
davkean opened this issue Jul 12, 2017 · 0 comments
Closed

ProjectInstance.GetItemsByItemTypeAndEvaluatedInclude allocates ~0.8% of open solution #2283

davkean opened this issue Jul 12, 2017 · 0 comments
Labels
performance triaged

Comments

@davkean
Copy link
Member

davkean commented Jul 12, 2017 •
edited
Loading

ProjectInstance.GetItemsByItemTypeAndEvaluatedInclude is about 0.8% of opening ProjectSystem.sln:

image

Looking at the implementation, it looks like this could be written a lot more efficiently to avoid the:

  • Capture class
  • Where LINQ enumerator
  • Func delegate creation
  • ReadOnlyCollection allocations that immediately thrown away
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davkean @AR-May