Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetInstalledSDKLocations runs in every project regardless of whether they even target a Windows SDK #2443

Closed
davkean opened this issue Aug 16, 2017 · 2 comments
Closed

GetInstalledSDKLocations runs in every project regardless of whether they even target a Windows SDK #2443

davkean opened this issue Aug 16, 2017 · 2 comments
Labels
bug performance triaged

Comments

@davkean
Copy link
Member

davkean commented Aug 16, 2017 •
edited
Loading

GetInstalledSDKLocations target runs in every project regardless of whether the project has any SDKs. Can we put a condition on it so that only if there are SDKReferences do we run it?

https://github.com/Microsoft/msbuild/blob/d0d089c1c845bb51f6567593e00403b1ca94f65c/src/Tasks/Microsoft.Common.CurrentVersion.targets#L2163-L2200
@davkean davkean mentioned this issue Aug 16, 2017
Closed
@rainersigwald
Copy link
Member

All of the tasks within it are conditioned on '@(SDKReference)' != ''; seems like we could promote that.

@davkean
Copy link
Member Author

davkean commented Aug 29, 2017

Make note this with the telemetry we've captured this is currently the 12th slowest target across all MS targets.

@jeffkl jeffkl self-assigned this Aug 29, 2017
jeffkl added a commit to jeffkl/msbuild that referenced this issue Aug 29, 2017
@jeffkl
Add condition to GetInstalledSDKLocations
e17932b 
All tasks in the target already have a condition '@(SDKReference)' != '' so to improve performance we can condition the target instead

Fixes dotnet#2443
@jeffkl jeffkl mentioned this issue Aug 29, 2017
Merged
AndyGerlicher pushed a commit that referenced this issue Aug 30, 2017
@jeffkl @AndyGerlicher
Add condition to GetInstalledSDKLocations (#2482)
63e4e46 
All tasks in the target already have a condition '@(SDKReference)' != '' so to improve performance we can condition the target instead

Fixes #2443
@davkean davkean mentioned this issue Oct 6, 2017
Closed
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug performance triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davkean @rainersigwald @jeffkl @AR-May