Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allocate in TaskItem.GetHashCode #2267

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Do not allocate in TaskItem.GetHashCode #2267

merged 1 commit into from
Jul 10, 2017

Conversation

davkean
Copy link
Member

@davkean davkean commented Jul 6, 2017

This was causing about 0.3% of allocations (12 MB) of a particular scenario installing NuGet packages.

jeffkl
jeffkl approved these changes Jul 6, 2017
View reviewed changes
Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if any other places are doing this as well

@davkean
Copy link
Member Author

davkean commented Jul 6, 2017

While I didn't search MSBuild's code base - I did look for every GetHashCode that allocated enough to hit PerfView's threshold, and either fixed them or filed them. There were no more MSBuild ones.

rainersigwald
rainersigwald approved these changes Jul 6, 2017
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a nice fix.

@davkean
Copy link
Member Author

davkean commented Jul 9, 2017

@rainersigwald @jeffkl Can one you merge this in? I don't have permissions.

@davkean @rainersigwald
Do not allocate in TaskItem.GetHashCode
6d8b004 
This was causing about 0.3% of allocations (12 MB) of a particular scenario installing NuGet packages.
@rainersigwald rainersigwald self-assigned this Jul 10, 2017
@davkean
Copy link
Member Author

davkean commented Jul 10, 2017

Looks like the Ubuntu build is failing due to a timeout, unsure if this introduced it?

@rainersigwald
Copy link
Member

@dotnet-bot test Ubuntu16.04 Build for CoreCLR please

It passed on your change before, so I don't think it's related.

@rainersigwald rainersigwald merged commit 7b9ebba into dotnet:master Jul 10, 2017
@rainersigwald rainersigwald removed their assignment Jul 10, 2017
@davkean
Copy link
Member Author

davkean commented Jul 10, 2017

Thanks @rainersigwald!

@davkean davkean mentioned this pull request Aug 15, 2017
Closed
@davkean davkean deleted the GetHashCode branch September 6, 2017 07:03
@davkean davkean mentioned this pull request Sep 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdmihai cdmihai cdmihai approved these changes

@rainersigwald rainersigwald rainersigwald approved these changes

@AndyGerlicher AndyGerlicher AndyGerlicher approved these changes

@jeffkl jeffkl jeffkl approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davkean @rainersigwald @cdmihai @AndyGerlicher @jeffkl @dnfclas