Remove unnecessary List<T> instantiation #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the cause of a large amount (1.2%) of allocations in a large project some of which end up on the large object heap.
|
tag @Pilchie |
AndyGerlicher
approved these changes
Oct 5, 2017
Pilchie
approved these changes
Oct 5, 2017
| @@ -401,13 +401,10 @@ private LazyItemList GetItemList(string itemType) | |||
| return ret; | |||
| } | |||
|
|
|||
| public IList<ItemData> GetAllItems() | |||
| public IEnumerable<ItemData> GetAllItems() | |||
There was a problem hiding this comment.
Might be worth at least commenting that this is deferred, so that callers can be careful about multiple enumerations. Or consider changing the name to make it more clear.
Gives a better indication not to iterate multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the cause of a large amount (1.2%) of allocations in a large project, some of which end up on the large object heap.
Large project from a partner:
Smaller project with mix of .NET Framework/.NET Standard projects:
