Error message was not direct enough. #4183
Conversation
src/fsharp/FSComp.txt
Outdated
| @@ -1041,8 +1041,8 @@ lexHashBangMustBeFirstInFile,"#! may only appear as the first line at the start | |||
| 1186,parsInvalidProperty,"Invalid property getter or setter" | |||
| 1187,parsIndexerPropertyRequiresAtLeastOneArgument,"An indexer property must be given at least one argument" | |||
| 1188,tastInvalidAddressOfMutableAcrossAssemblyBoundary,"This operation accesses a mutable top-level value defined in another assembly in an unsupported way. The value cannot be accessed through its address. Consider copying the expression to a mutable local, e.g. 'let mutable x = ...', and if necessary assigning the value back after the completion of the operation" | |||
| 1189,parsNonAdjacentTypars,"Type parameters must be placed directly adjacent to the type name, e.g. \"type C<'T>\", not type \"C <'T>\"" | |||
| 1190,parsNonAdjacentTyargs,"Type arguments must be placed directly adjacent to the type name, e.g. \"C<'T>\", not \"C <'T>\"" | |||
| 1189,parsNonAdjacentTypars,"Remove spaces after type, e.g. \"type C<'T>\", not type \"C <'T>\" type parameters must be placed directly adjacent to the type name" | |||
There was a problem hiding this comment.
Suggested change:
Remove spaces between the type name and type parameter, e.g. \"type C<'T>\", not type \"C <'T>\". Type parameters must be placed directly adjacent to the type name
This way it's a bit more specific about what the issue is. It also fixes a run-on sentence.
There was a problem hiding this comment.
Yes that sounds better. Thanks.
There was a problem hiding this comment.
Like a twerp I looked at the conversation, not the files :-(
There was a problem hiding this comment.
@KevinRansom what does that mean? Is something wrong?
There was a problem hiding this comment.
@voronoipotato no, I nothing is wrong.
|
@dotnet-bot test this please |
|
@dotnet-bot test this please @voronoipotato would you like to make the suggested change? |
|
sure I can do that. |
|
sorry about the bumpy ride here, first time doing a pull request on a project with a significant number of contributors. |
|
No worries! |
|
@brettfo Any idea about what this error in CI is about?
|
|
@dotnet-bot test this please |
|
@cartermp phillip ... that is a notification that the xlif files are not uptodate. You need to ensure they are upto date. The cli machine does not edit PRs use these commands to update the pr: |
|
Oh beans I deleted my repository. Is this a problem? |
|
@voronoipotato no probs mate, apparently git hub is smart enough to cope with that kind of thing. Kevin |
Scott Nimrod, otherwise completely capable F# developer was flummoxed by this in a live stream. Added clear resolution steps to error message. It's a rather roundabout way to say "You've got an extra space there".
https://youtu.be/_6jV1n0fL00?t=10m25s